Move returns before goto when applicable. #4774
Conversation
|
This could be done when any of the returned variables is remapped. Code quote: let mut return_vars = returned_vars.to_vec();
return_vars.pop();
return_vars.push(*remapped_return);
self.fixes.push(FixInfo { block_id, return_vars }); |
ilyalesokhin-starkware
force-pushed
the
ilya/returned_opt
branch
2 times, most recently
from
a7856a0 to
d827fdf
Compare
There was a problem hiding this comment.
Reviewed 91 of 96 files at r1, 4 of 4 files at r2, 9 of 9 files at r3.
Reviewable status: 104 of 105 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-lowering/src/db.rs line 377 at r2 (raw file):
return_optimization(db, &mut lowered); // optimize_remappings(&mut lowered);
?
ilyalesokhin-starkware
force-pushed
the
ilya/returned_opt
branch
from
d827fdf to
1535e29
Compare
There was a problem hiding this comment.
Reviewable status: 104 of 105 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-lowering/src/db.rs line 377 at r2 (raw file):
Previously, orizi wrote…
?
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
ilyalesokhin-starkware
force-pushed
the
ilya/returned_opt
branch
from
1535e29 to
677ea1c
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status:
ilyalesokhin-starkware
force-pushed
the
ilya/returned_opt
branch
from
677ea1c to
a652e65
Compare
This change is